From 48f0a923ee13b27d271990c95a7b5515f092ab11 Mon Sep 17 00:00:00 2001
From: Svante Schubert <svante.schubert@gmail.com>
Date: Fri, 25 Nov 2022 12:48:24 +0100
Subject: [PATCH 1/2] Enabling Maven builds for push and pull requests on
 Ubuntu in the GitHub cloud

---
 .github/workflows/maven.yml | 22 ++++++++++++++++++++++
 Mustang-CLI/pom.xml         | 10 +++++-----
 library/pom.xml             | 14 +++++++-------
 pom.xml                     |  4 ++--
 validator/pom.xml           | 14 +++++++-------
 5 files changed, 43 insertions(+), 21 deletions(-)
 create mode 100644 .github/workflows/maven.yml

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
new file mode 100644
index 00000000..c60194b3
--- /dev/null
+++ b/.github/workflows/maven.yml
@@ -0,0 +1,22 @@
+# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time
+# For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven
+# For setup-java see: https://github.com/actions/setup-java#Usage 
+
+name: Java CI with Maven
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-java@v3 # the log states the default ~/.m2/toolchains.xml is being created pointing to the JDK
+      with:
+        distribution: 'adopt' # for latest JDKs use temurin https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/
+        java-version: '8'
+        cache: 'maven'
+    - name: Build with Maven
+      run: mvn -B package --file pom.xml
\ No newline at end of file
diff --git a/Mustang-CLI/pom.xml b/Mustang-CLI/pom.xml
index 9bfa64f0..f40d7838 100644
--- a/Mustang-CLI/pom.xml
+++ b/Mustang-CLI/pom.xml
@@ -13,9 +13,9 @@
    <version>2.5.8-SNAPSHOT</version>
    <properties>
       <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-      <maven.compiler.compilerVersion>1.8</maven.compiler.compilerVersion>
-      <maven.compiler.source>1.8</maven.compiler.source>
-      <maven.compiler.target>1.8</maven.compiler.target>
+      <maven.compiler.compilerVersion>8</maven.compiler.compilerVersion>
+      <maven.compiler.source>8</maven.compiler.source>
+      <maven.compiler.target>8</maven.compiler.target>
    </properties>
    <dependencies>
       <dependency>
@@ -101,8 +101,8 @@
             <configuration>
                <toolchains>
                   <jdk>
-                     <version>1.8</version>
-                     <vendor>openjdk</vendor>
+                     <version>8</version>
+                     <vendor>adopt</vendor>
                   </jdk>
                </toolchains>
             </configuration>
diff --git a/library/pom.xml b/library/pom.xml
index 8565a8e4..db8d8ed4 100644
--- a/library/pom.xml
+++ b/library/pom.xml
@@ -45,9 +45,9 @@
 		<github.global.server>github</github.global.server>
 		<additionalparam>-Xdoclint:none</additionalparam>
 		<!-- Skip error check for javadoc -->
-		<maven.compiler.compilerVersion>1.8</maven.compiler.compilerVersion>
-		<maven.compiler.source>1.8</maven.compiler.source>
-		<maven.compiler.target>1.8</maven.compiler.target>
+		<maven.compiler.compilerVersion>8</maven.compiler.compilerVersion>
+		<maven.compiler.source>8</maven.compiler.source>
+		<maven.compiler.target>8</maven.compiler.target>
 		<maven.deploy.skip>true</maven.deploy.skip><!-- do deploy to maven central, parent project does not and inherits -->
 
 	</properties>
@@ -138,8 +138,8 @@
 					<!-- http://stackoverflow.com/questions/574594/how-can-i-create-an-executable-jar-with-dependencies-using-maven
                         mvn clean compile assembly:single -->
 					<!-- or whatever version you use -->
-					<source>1.8</source>
-					<target>1.8</target>
+					<source>8</source>
+					<target>8</target>
 				</configuration>
 			</plugin>
 			<plugin>
@@ -156,8 +156,8 @@
 				<configuration>
 					<toolchains>
 						<jdk>
-							<version>1.8</version>
-							<vendor>openjdk</vendor>
+							<version>8</version>
+							<vendor>adopt</vendor>
 						</jdk>
 					</toolchains>
 				</configuration>
diff --git a/pom.xml b/pom.xml
index 7c64e368..1dbe2423 100644
--- a/pom.xml
+++ b/pom.xml
@@ -192,8 +192,8 @@
                         <configuration>
                             <toolchains>
                                 <jdk>
-                                    <version>1.8</version>
-                                    <vendor>openjdk</vendor>
+                                    <version>8</version>
+                                    <vendor>adopt</vendor>
                                 </jdk>
                             </toolchains>
                         </configuration>
diff --git a/validator/pom.xml b/validator/pom.xml
index 62770c6e..ca728123 100644
--- a/validator/pom.xml
+++ b/validator/pom.xml
@@ -29,9 +29,9 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <maven.deploy.skip>false
         </maven.deploy.skip><!-- do deploy to maven central, parent project does not and inherits -->
-        <maven.compiler.compilerVersion>1.8</maven.compiler.compilerVersion>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
+        <maven.compiler.compilerVersion>8</maven.compiler.compilerVersion>
+        <maven.compiler.source>8</maven.compiler.source>
+        <maven.compiler.target>8</maven.compiler.target>
 
     </properties>
     <dependencies>
@@ -156,8 +156,8 @@
                 <configuration>
                     <toolchains>
                         <jdk>
-                            <version>1.8</version>
-                            <vendor>openjdk</vendor>
+                            <version>8</version>
+                            <vendor>adopt</vendor>
                         </jdk>
                     </toolchains>
                 </configuration>
@@ -173,8 +173,8 @@
                     <!-- http://stackoverflow.com/questions/574594/how-can-i-create-an-executable-jar-with-dependencies-using-maven
                              mvn clean compile assembly:single -->
                     <!-- or whatever version you use -->
-                    <source>1.8</source>
-                    <target>1.8</target>
+                    <source>8</source>
+                    <target>8</target>
                 </configuration>
             </plugin>
             <!-- /ZUV -->

From fb7dd3c931002ff60e158b24926c9d485ad8fc11 Mon Sep 17 00:00:00 2001
From: Svante Schubert <svante.schubert@gmail.com>
Date: Fri, 25 Nov 2022 12:48:24 +0100
Subject: [PATCH 2/2] Enabling Maven builds for push and pull requests on
 Ubuntu in the GitHub cloud

---
 .github/workflows/maven.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index c60194b3..adcbf92a 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -17,6 +17,6 @@ jobs:
       with:
         distribution: 'adopt' # for latest JDKs use temurin https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/
         java-version: '8'
-        cache: 'maven'
+        cache: 'maven' #cache/restore any dependencies to improve the workflow execution time
     - name: Build with Maven
       run: mvn -B package --file pom.xml
\ No newline at end of file