From 11bbcbaf5c302692ba883e9756fe3a137602a8a1 Mon Sep 17 00:00:00 2001
From: Sebastian Sieber <sieber@weclapp.com>
Date: Thu, 13 Jul 2023 09:59:11 +0200
Subject: [PATCH] Use StringBuilder

---
 .../ZUGFeRD/ZUGFeRD2PullProvider.java         | 28 +++++++++++--------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java b/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java
index 30da37cd..c45d628a 100644
--- a/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java
+++ b/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java
@@ -742,28 +742,32 @@ public class ZUGFeRD2PullProvider implements IXMLProvider {
 	}
 
   private static String buildNotes(IExportableTransaction trans) {
-    String notes = "";
+    StringBuilder notes = new StringBuilder();
     if (trans.getNotes() != null) {
       for (final String currentNote : trans.getNotes()) {
-        notes += "<ram:IncludedNote><ram:Content>" + XMLTools.encodeXML(currentNote) + "</ram:Content></ram:IncludedNote>";
+        notes.append("<ram:IncludedNote><ram:Content>")
+            .append(XMLTools.encodeXML(currentNote))
+            .append("</ram:Content></ram:IncludedNote>");
       }
     }
     if (trans.rebateAgreementExists()) {
-      notes += "<ram:IncludedNote><ram:Content>"
-          + "Es bestehen Rabatt- und Bonusvereinbarungen.</ram:Content>"
-          + "<ram:SubjectCode>AAK</ram:SubjectCode></ram:IncludedNote>";
+      notes.append("<ram:IncludedNote><ram:Content>")
+          .append("Es bestehen Rabatt- und Bonusvereinbarungen.</ram:Content>")
+          .append("<ram:SubjectCode>AAK</ram:SubjectCode></ram:IncludedNote>");
     }
     if (trans.getOwnOrganisationFullPlaintextInfo() != null) {
-      notes += "<ram:IncludedNote><ram:Content>"
-          + XMLTools.encodeXML(trans.getOwnOrganisationFullPlaintextInfo()) + "</ram:Content>"
-          + "<ram:SubjectCode>REG</ram:SubjectCode></ram:IncludedNote>";
+      notes.append("<ram:IncludedNote><ram:Content>")
+          .append(XMLTools.encodeXML(trans.getOwnOrganisationFullPlaintextInfo()))
+          .append("</ram:Content>")
+          .append("<ram:SubjectCode>REG</ram:SubjectCode></ram:IncludedNote>");
     }
     if (trans.getSubjectNote() != null) {
-      notes += "<ram:IncludedNote><ram:Content>"
-          + XMLTools.encodeXML(trans.getSubjectNote()) + "</ram:Content>"
-          + "</ram:IncludedNote>";
+      notes.append("<ram:IncludedNote><ram:Content>")
+          .append(XMLTools.encodeXML(trans.getSubjectNote()))
+          .append("</ram:Content>")
+          .append("</ram:IncludedNote>");
     }
-    return notes;
+    return notes.toString();
   }
 
   @Override