From 13629e92d6e0d3983e518fdd5e77db58f8a38302 Mon Sep 17 00:00:00 2001 From: danl-devp <153179194+danl-devp@users.noreply.github.com> Date: Mon, 15 Dec 2025 09:29:10 +0100 Subject: [PATCH] 859: Remove duplicate paymentTerms --- .../ZUGFeRD/ZUGFeRD2PullProvider.java | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java b/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java index 1688cf5c..f326c339 100644 --- a/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java +++ b/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java @@ -1010,11 +1010,23 @@ public class ZUGFeRD2PullProvider implements IXMLProvider { private String buildPaymentTermsXml() { - ArrayList paymentTerms = new ArrayList(Arrays.asList(trans.getExtendedPaymentTerms())); + ArrayList paymentTerms = new ArrayList<>(); + { + // add payment terms + { + IZUGFeRDPaymentTerms izpt = trans.getPaymentTerms(); + if (izpt != null) { + paymentTerms.add(izpt); + } + } - IZUGFeRDPaymentTerms izpt= trans.getPaymentTerms(); - if (izpt!=null) { - paymentTerms.add(izpt); + // add extended payment terms (except the first one which is already added above) + { + IZUGFeRDPaymentTerms[] extendedPaymentTerms = trans.getExtendedPaymentTerms(); + for (int i = 1; i < extendedPaymentTerms.length; i++) { + paymentTerms.add(extendedPaymentTerms[i]); + } + } } String paymentTermsXml = "";