closes #392

History.md

@@ -6,6 +6,8 @@
 - jakarta support #372
 - Upgrade to PDFBox 3 #373
 - #397
+- #392 CLI: action combine: --ignorefileextension to ignore PDF/A input file errors dosen't work
+- for CLI combine, fx is now default
 
 2.11.0
 =======

Mustang-CLI/src/main/java/org/mustangproject/commandline/Main.java

@@ -36,6 +36,7 @@ import java.util.ArrayList;
 
 public class Main {
 	private static org.slf4j.Logger LOGGER; // log output
+
 	private static void printUsage() {
 		System.err.println(getUsage());
 	}
@@ -344,18 +345,18 @@ public class Main {
 			attachmentOpt.setArgs(Option.UNLIMITED_VALUES);
 
 			options.addOption(attachmentOpt);
-			options.addOption(new Option("source", "source",true, "which source file to use"));
+			options.addOption(new Option("source", "source", true, "which source file to use"));
-			options.addOption(new Option("source-xml", "source-xml",true, "which source file to use"));
+			options.addOption(new Option("source-xml", "source-xml", true, "which source file to use"));
-			options.addOption(new Option("language", "language",true, "output language (en, de or fr)"));
+			options.addOption(new Option("language", "language", true, "output language (en, de or fr)"));
-			options.addOption(new Option("out", "out",true, "which output file to write to"));
+			options.addOption(new Option("out", "out", true, "which output file to write to"));
-			options.addOption(new Option("no-notices", "no-notices",false, "suppress non-fatal errors"));
+			options.addOption(new Option("no-notices", "no-notices", false, "suppress non-fatal errors"));
-			options.addOption(new Option("logAppend", "logAppend",true, "freeform text to be appended to log messages"));
+			options.addOption(new Option("logAppend", "logAppend", true, "freeform text to be appended to log messages"));
 			options.addOption(new Option("disable-file-logging", "disable-file-logging", false, "suppress logging to file"));
-			options.addOption(new Option("d", "directory",true, "which directory to operate on"));
+			options.addOption(new Option("d", "directory", true, "which directory to operate on"));
-			options.addOption(new Option("i", "ignorefileextension",false, "ignore non-matching file extensions"));
+			options.addOption(new Option("i", "ignorefileextension", false, "ignore non-matching file extensions"));
-			options.addOption(new Option("l", "listfromstdin",false, "take list of files from commandline"));
+			options.addOption(new Option("l", "listfromstdin", false, "take list of files from commandline"));
 
-			boolean optionsRecognized=false;
+			boolean optionsRecognized = false;
 			String action = "";
 
 			Boolean disableFileLogging = false;
@@ -367,7 +368,7 @@ public class Main {
 				String directoryName = cmd.getOptionValue("directory");
 				Boolean filesFromStdIn = cmd.hasOption("listfromstdin");//((Number)cmdLine.getParsedOptionValue("integer-option")).intValue();
 				Boolean ignoreFileExt = cmd.hasOption("ignorefileextension");
-				Boolean helpRequested = cmd.hasOption("help")  || ((action!=null)&&(action.equals("help")));
+				Boolean helpRequested = cmd.hasOption("help") || ((action != null) && (action.equals("help")));
 				disableFileLogging = cmd.hasOption("disable-file-logging");
 
 				String sourceName = cmd.getOptionValue("source");
@@ -383,14 +384,12 @@ public class Main {
 				String[] attachmentFilenames = cmd.hasOption("attachments") ? cmd.getOptionValues("attachments") : null;
 
 
-
+				ArrayList<FileAttachment> attachments = new ArrayList<>();
-
-				ArrayList<FileAttachment> attachments=new ArrayList <>();
 				/*
 					setting system property to disable FILE appender and
 					suppress creation of files and folders.
 				 */
-				System.setProperty("FILE_APPENDER_ENABLED",  ((Boolean)(disableFileLogging==false)).toString());
+				System.setProperty("FILE_APPENDER_ENABLED", ((Boolean) (disableFileLogging == false)).toString());
 
 				LOGGER = LoggerFactory.getLogger(org.slf4j.Logger.ROOT_LOGGER_NAME);
 
@@ -600,7 +599,7 @@ public class Main {
 
 			if (format == null) {
 				try {
-					format = getStringFromUser("Format (fx=Factur-X, zf=ZUGFeRD, ox=Order-X, da=Cross Industry Despatch Advice)", "zf", "fx|zf|ox|da");
+					format = getStringFromUser("Format (fx=Factur-X, zf=ZUGFeRD, ox=Order-X, da=Cross Industry Despatch Advice)", "fx", "fx|zf|ox|da");
 				} catch (Exception e) {
 					LOGGER.error(e.getMessage(), e);
 				}
@@ -610,7 +609,7 @@ public class Main {
 
 			if (zfVersion == null) {
 				try {
-					zfVersion = getStringFromUser("Version (1 or 2)", Integer.toString(ZUGFeRDExporterFromA3.DefaultZUGFeRDVersion), "1|2");
+					zfVersion = getStringFromUser("Version (1 or 2)", "1", "1|2");//fx default version is 1
 				} catch (Exception e) {
 					LOGGER.error(e.getMessage(), e);
 				}
@@ -694,41 +693,33 @@ public class Main {
 			IZUGFeRDExporter ze = null;
 			// All params are good! continue...
 			if (format.equals("ox")) {
-				ze = new OXExporterFromA1().setProducer("Mustang-cli")
+				ze = new OXExporterFromA1();
-					.setZUGFeRDVersion(zfIntVersion)
-					.setCreator(System.getProperty("user.name")).setProfile(zfConformanceLevelProfile);
 				if (ignoreInputErrors) {
 					((OXExporterFromA1) ze).ignorePDFAErrors();
 				}
-
 			} else if (format.equals("da")) {
-				ze = new DXExporterFromA1().setProducer("Mustang-cli")
+				ze = new DXExporterFromA1();
-					.setZUGFeRDVersion(zfIntVersion)
-					.setCreator(System.getProperty("user.name")).setProfile(zfConformanceLevelProfile);
-
 				if (ignoreInputErrors) {
 					((DXExporterFromA1) ze).ignorePDFAErrors();
 				}
-
 			} else {
 				if (format.equals("fx")) {
-					zfIntVersion=2;// actually we are talking of generation, not version
+					zfIntVersion = 2;// actually we are talking of generation, not version
 					// so even if someone correctly requested factur-x 1 internally we call it zugferd 2 :-(
 				}
-				ze = new ZUGFeRDExporterFromPDFA().load(pdfName);
+				ze = new ZUGFeRDExporterFromPDFA();
-
-					ze.setProducer("Mustang-cli")
-					.setZUGFeRDVersion(zfIntVersion)
-					.setCreator(System.getProperty("user.name")).setProfile(zfConformanceLevelProfile);
 				if (ignoreInputErrors) {
-					((ZUGFeRDExporterFromA1) ze).ignorePDFAErrors();
+					((ZUGFeRDExporterFromPDFA)ze).ignorePDFAErrors();
 				}
 			}
 			for (FileAttachment attachment : attachments) {
 				((ZUGFeRDExporterFromA3) ze).attachFile(attachment.getFilename(), attachment.getData(), attachment.getMimetype(), attachment.getRelation());
 			}
 
-//			ze = ze.load(pdfName);
+			ze.load(pdfName);
+			ze.setProducer("Mustang-cli")
+				.setZUGFeRDVersion(zfIntVersion)
+				.setCreator(System.getProperty("user.name")).setProfile(zfConformanceLevelProfile);
 
 			if (format.equals("zf")) {
 				ze.disableFacturX();

library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRDExporterFromA1.java

@@ -31,12 +31,6 @@ import org.mustangproject.EStandard;
 import jakarta.activation.DataSource;
 
 public class ZUGFeRDExporterFromA1 extends ZUGFeRDExporterFromA3 implements IZUGFeRDExporter {
-	protected boolean ignorePDFAErrors = false;
-
-	public ZUGFeRDExporterFromA1 ignorePDFAErrors() {
-		this.ignorePDFAErrors = true;
-		return this;
-	}
 
 	private static boolean isValidA1(DataSource dataSource) throws IOException {
 		return getPDFAParserValidationResult(PreflightParserHelper.createPreflightParser(dataSource));

library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRDExporterFromA3.java

@@ -80,7 +80,12 @@ public class ZUGFeRDExporterFromA3 extends XRExporter implements IZUGFeRDExporte
 	private boolean isFacturX = true;
 
 	public static final int DefaultZUGFeRDVersion = 2;
+	protected boolean ignorePDFAErrors = false;
 
+	public ZUGFeRDExporterFromA3 ignorePDFAErrors() {
+		this.ignorePDFAErrors = true;
+		return this;
+	}
 	protected PDFAConformanceLevel conformanceLevel = PDFAConformanceLevel.UNICODE;
 	protected ArrayList<FileAttachment> fileAttachments = new ArrayList<FileAttachment>();
 

library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRDExporterFromPDFA.java

@@ -49,14 +49,28 @@ public class ZUGFeRDExporterFromPDFA implements IZUGFeRDExporter {
 
 	protected IZUGFeRDExporter theExporter;
 
+	protected boolean ignorePDFAErrors = false;
+
+	public ZUGFeRDExporterFromPDFA ignorePDFAErrors() {
+		this.ignorePDFAErrors = true;
+		return this;
+	}
 	protected void determineAndSetExporter(int PDFAVersion) {
 		if (PDFAVersion == 3) {
 			theExporter = new ZUGFeRDExporterFromA3();
+			if (ignorePDFAErrors) {
+				((ZUGFeRDExporterFromA3)theExporter).ignorePDFAErrors();
+			}
 		} else if (PDFAVersion == 1) {
 			theExporter = new ZUGFeRDExporterFromA1();
+			if (ignorePDFAErrors) {
+				((ZUGFeRDExporterFromA1)theExporter).ignorePDFAErrors();
+			}
 		} else {
 			throw new IllegalArgumentException("PDF-A version not supported");
 		}
+
+
 	}
 	protected IZUGFeRDExporter getExporter() {
 		if (theExporter==null) {

library/src/test/java/org/mustangproject/ZUGFeRD/PreValidationTest.java

@@ -59,10 +59,11 @@ public class PreValidationTest extends TestCase {
 		hasEx = false;
 		try (InputStream source = this.getClass()
 			.getResourceAsStream(SOURCE_PDF)) {
-			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application").ignorePDFAErrors()
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2)
+			ze.ignorePDFAErrors().load(source);
-				.load(source);
+
-			ze.setTransaction(createInvoice());
+			ze.setProducer("My Application").setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).
+				setTransaction(createInvoice());
 			ze.export(TARGET_PDF);
 		} catch (IOException e) {
 			hasEx = true;

library/src/test/java/org/mustangproject/ZUGFeRD/ZF2EdgeTest.java

@@ -293,12 +293,15 @@ public class ZF2EdgeTest extends MustangReaderTestCase implements IExportableTra
 
 		// the writing part
 
-		try (InputStream SOURCE_PDF = this.getClass()
+		try  {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();ze.ignorePDFAErrors();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("Extended")).ignorePDFAErrors()
+			ze.load(SOURCE_PDF);
-					 .load(SOURCE_PDF)) {
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("Extended"));
+
 			ze.setTransaction(this);
 			String theXML = new String(ze.getProvider().getXML(), StandardCharsets.UTF_8);
 			assertTrue(theXML.contains("<rsm:CrossIndustryInvoice"));

library/src/test/java/org/mustangproject/ZUGFeRD/ZF2PushTest.java

@@ -72,14 +72,15 @@ public class ZF2PushTest extends TestCase {
 		SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
 
 		BigDecimal price = new BigDecimal(priceStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20201121_508blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).ignorePDFAErrors()
+			ze.ignorePDFAErrors();
-					 .load(SOURCE_PDF)) {
+			ze.load(SOURCE_PDF);
-
+			ze.setProducer("My Application")
-
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2);
 			ze.setTransaction(new Invoice().setDueDate(sdf.parse("2020-12-12")).setIssueDate(sdf.parse("2020-11-21")).setDeliveryDate(sdf.parse("2020-11-10"))
 				.setSender(new TradeParty(orgname, "Ecke 12", "12345", "Stadthausen", "DE").addBankDetails(new BankDetails("DE88200800000970375700", "COBADEFFXXX").setAccountName("Max Mustermann")).addVATID("DE136695976"))
 				.setRecipient(new TradeParty("Theodor Est", "Bahnstr. 42", "88802", "Spielkreis", "DE")
@@ -125,12 +126,14 @@ public class ZF2PushTest extends TestCase {
 		String priceStr = "1.00";
 		String taxID = "9990815";
 		BigDecimal price = new BigDecimal(priceStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-				 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).ignorePDFAErrors()
+			ze.ignorePDFAErrors();
-				 .load(SOURCE_PDF)) {
+			ze.load(SOURCE_PDF);
+			ze.setProducer("My Application").setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2);
 
 			byte[] b = {12, 13};
 			ze.attachFile("one.pdf", b, "application/pdf", "Alternative");
@@ -163,6 +166,7 @@ public class ZF2PushTest extends TestCase {
 
 
 	}
+
 	public void testBankTransferExport() {
 
 		String orgname = "Test company";
@@ -170,22 +174,24 @@ public class ZF2PushTest extends TestCase {
 		String priceStr = "1.00";
 		String taxID = "9990815";
 		BigDecimal price = new BigDecimal(priceStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-				 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).ignorePDFAErrors()
+			ze.ignorePDFAErrors().load(SOURCE_PDF);
-				 .load(SOURCE_PDF)) {
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2);
 
-			String IBAN="DE999888777";
+			String IBAN = "DE999888777";
-			String BIC="COBADEFXXX";
+			String BIC = "COBADEFXXX";
-			BankDetails bd=new BankDetails(IBAN, BIC);
+			BankDetails bd = new BankDetails(IBAN, BIC);
 			ze.setTransaction(new Invoice().setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname, "teststr", "55232", "teststadt", "DE").addBankDetails(bd).addTaxID(taxID)).setOwnVATID("DE0815").setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE").addVATID("DE4711").setContact(new Contact("Franz Müller", "01779999999", "franz@mueller.de", "teststr. 12", "55232", "Entenhausen", "DE"))).setNumber(number).addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), price, new BigDecimal(1.0)))
 
 			);
 			String theXML = new String(ze.getProvider().getXML());
-			Invoice read=new Invoice();
+			Invoice read = new Invoice();
-			ZUGFeRDInvoiceImporter zii=new ZUGFeRDInvoiceImporter(new ByteArrayInputStream(theXML.getBytes(StandardCharsets.UTF_8)));
+			ZUGFeRDInvoiceImporter zii = new ZUGFeRDInvoiceImporter(new ByteArrayInputStream(theXML.getBytes(StandardCharsets.UTF_8)));
 			zii.extractInto(read);
 			assertTrue(theXML.contains("<rsm:CrossIndustryInvoice"));
 
@@ -208,12 +214,14 @@ public class ZF2PushTest extends TestCase {
 		String number = "123";
 		String amountStr = "3.00";
 		BigDecimal amount = new BigDecimal(amountStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile("extended").ignorePDFAErrors()
+			ze.ignorePDFAErrors().load(SOURCE_PDF);
-					 .load(SOURCE_PDF)) {
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile("extended");
 			//	ze.setTransaction(new Invoice().setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname,"teststr", "55232","teststadt","DE")).setOwnTaxID("4711").setOwnVATID("DE0815").setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE")).setNumber(number)
 			//					.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), amount, new BigDecimal(1.0)).addAllowance(new Allowance().setPercent(new BigDecimal(50)))));
 
@@ -259,12 +267,14 @@ public class ZF2PushTest extends TestCase {
 		String number = "123";
 		String amountStr = "3.00";
 		BigDecimal amount = new BigDecimal(amountStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile("extended").ignorePDFAErrors()
+			ze.ignorePDFAErrors().load(SOURCE_PDF);
-					 .load(SOURCE_PDF)) {
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile("extended");
 			//	ze.setTransaction(new Invoice().setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname,"teststr", "55232","teststadt","DE")).setOwnTaxID("4711").setOwnVATID("DE0815").setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE")).setNumber(number)
 			//					.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), amount, new BigDecimal(1.0)).addAllowance(new Allowance().setPercent(new BigDecimal(50)))));
 
@@ -312,12 +322,15 @@ public class ZF2PushTest extends TestCase {
 		String number = "123";
 		String amountStr = "3.00";
 		BigDecimal amount = new BigDecimal(amountStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile("extended").ignorePDFAErrors()
+			ze.ignorePDFAErrors().load(SOURCE_PDF);
-					 .load(SOURCE_PDF)) {
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile("extended");
+
 			//	ze.setTransaction(new Invoice().setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname,"teststr", "55232","teststadt","DE")).setOwnTaxID("4711").setOwnVATID("DE0815").setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE")).setNumber(number)
 			//					.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), amount, new BigDecimal(1.0)).addAllowance(new Allowance().setPercent(new BigDecimal(50)))));
 
@@ -354,18 +367,22 @@ public class ZF2PushTest extends TestCase {
 
 
 	}
+
 	public void testChargesAllowancesExport() {
 
 		String orgname = "Test company";
 		String number = "123";
 		String amountStr = "3.00";
 		BigDecimal amount = new BigDecimal(amountStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("en16931")).ignorePDFAErrors()
+			ze.ignorePDFAErrors()
-					 .load(SOURCE_PDF)) {
+				.load(SOURCE_PDF);
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("en16931"));
 
 			ze.setTransaction(new Invoice().setCurrency("CHF").setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname, "teststr", "55232", "teststadt", "DE")).setOwnTaxID("4711").setOwnVATID("DE0815").setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE")).setNumber(number)
 				.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), amount, new BigDecimal(1.0)))
@@ -413,18 +430,22 @@ public class ZF2PushTest extends TestCase {
 		String priceStr = "1.00";
 		String taxID = "9990815";
 		BigDecimal price = new BigDecimal(priceStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("extended")).ignorePDFAErrors()
+			ze.ignorePDFAErrors()
-					 .load(SOURCE_PDF)) {
+				.load(SOURCE_PDF);
+
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("extended"));
 
 			SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
 			try {
 
-				SchemedID gtin=new SchemedID("0160","2001015001325");
+				SchemedID gtin = new SchemedID("0160", "2001015001325");
-				SchemedID gln=new SchemedID("0088","4304171000002");
+				SchemedID gln = new SchemedID("0088", "4304171000002");
 				ze.setTransaction(new Invoice().setCurrency("CHF").addNote("document level 1/2").addNote("document level 2/2").setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date())
 					.setSellerOrderReferencedDocumentID("9384").setBuyerOrderReferencedDocumentID("28934")
 					.setDetailedDeliveryPeriod(new SimpleDateFormat("yyyyMMdd").parse(occurrenceFrom), new SimpleDateFormat("yyyyMMdd").parse(occurrenceTo))
@@ -435,7 +456,7 @@ public class ZF2PushTest extends TestCase {
 					.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(16)).addGlobalID(gtin).setSellerAssignedID("4711"), price, new BigDecimal(1.0)).addReferencedLineID("xxx").addNote("item level 1/1").addAllowance(new Allowance(new BigDecimal(0.02)).setReason("item discount").setTaxPercent(new BigDecimal(16))).setDetailedDeliveryPeriod(sdf.parse("2020-01-13"), sdf.parse("2020-01-15")))
 					.addCharge(new Charge(new BigDecimal(0.5)).setReason("quick delivery charge").setTaxPercent(new BigDecimal(16)))
 					.addAllowance(new Allowance(new BigDecimal(0.2)).setReason("discount").setTaxPercent(new BigDecimal(16)))
-						.addCashDiscount(new CashDiscount(new BigDecimal(2),14))
+					.addCashDiscount(new CashDiscount(new BigDecimal(2), 14))
 					.setDeliveryDate(sdf.parse("2020-11-02")).setOwnVATID("DE0815").setNumber(number).setVATDueDateTypeCode(EventTimeCodeTypeConstants.PAYMENT_DATE)
 				);
 			} catch (ParseException e) {
@@ -496,7 +517,6 @@ public class ZF2PushTest extends TestCase {
 		}
 
 
-
 	}
 
 	public void testAllowancesExport() {
@@ -504,12 +524,16 @@ public class ZF2PushTest extends TestCase {
 		String orgname = "Test company";
 		String number = "123";
 		BigDecimal qty = new BigDecimal("20");
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("en16931")).ignorePDFAErrors()
+			ze.ignorePDFAErrors().load(SOURCE_PDF);
-					 .load(SOURCE_PDF)) {
+
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("en16931"));
+
 
 			ze.setTransaction(new Invoice().setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname, "teststr", "55232", "teststadt", "DE")).setOwnTaxID("4711").setOwnVATID("DE0815").setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE")).setNumber(number)
 				.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), new BigDecimal(500.0), qty).addAllowance(new Allowance(new BigDecimal(300)).setTaxPercent(new BigDecimal(19))))
@@ -547,12 +571,16 @@ public class ZF2PushTest extends TestCase {
 		String number = "123";
 		String priceStr = "3.00";
 		BigDecimal price = new BigDecimal(priceStr);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("extended")).ignorePDFAErrors()
+			ze.ignorePDFAErrors()
-					 .load(SOURCE_PDF)) {
+				.load(SOURCE_PDF);
+
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).setProfile(Profiles.getByName("extended"));
 
 			ze.setTransaction(new Invoice().setCurrency("CHF").setDueDate(new Date()).setIssueDate(new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname, "teststr", "55232", "teststadt", "DE")).setOwnTaxID("4711").setOwnVATID("DE0815").setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE")).setNumber(number)
 				.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), price, new BigDecimal(1.0)))
@@ -599,12 +627,15 @@ public class ZF2PushTest extends TestCase {
 		String priceStr = "1.00";
 		BigDecimal price = new BigDecimal(priceStr);
 		BigDecimal qty = new BigDecimal(-1.0);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).ignorePDFAErrors()
+			ze.ignorePDFAErrors()
-					 .load(SOURCE_PDF)) {
+				.load(SOURCE_PDF);
+			ze.setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2);
 			// no due date, since we are not expecting money
 			Invoice i = new Invoice().setIssueDate(new Date()).setDetailedDeliveryPeriod(new Date(), new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname, "teststr", "55232", "teststadt", "DE").addTaxID("4711").addVATID("DE0815")).setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE").addVATID("DE0815")).setNumber(number)
 				.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), price, qty))
@@ -649,12 +680,16 @@ public class ZF2PushTest extends TestCase {
 		String priceStr = "1.00";
 		BigDecimal price = new BigDecimal(priceStr);
 		BigDecimal qty = new BigDecimal(1.0);
-		try (InputStream SOURCE_PDF = this.getClass()
+		try {
+			InputStream SOURCE_PDF = this.getClass()
 				.getResourceAsStream("/MustangGnuaccountingBeispielRE-20170509_505blanko.pdf");
 
-			 ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1().setProducer("My Application")
+			ZUGFeRDExporterFromA1 ze = new ZUGFeRDExporterFromA1();
-					 .setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2).ignorePDFAErrors()
+			ze.ignorePDFAErrors()
-					 .load(SOURCE_PDF)) {
+				.load(SOURCE_PDF);
+			ze.
+				setProducer("My Application")
+				.setCreator(System.getProperty("user.name")).setZUGFeRDVersion(2);
 			Invoice i = new Invoice().setIssueDate(new Date()).setDueDate(new Date()).setDetailedDeliveryPeriod(new Date(), new Date()).setDeliveryDate(new Date()).setSender(new TradeParty(orgname, "teststr", "55232", "teststadt", "DE").addTaxID("4711").addVATID("DE0815").addBankDetails(new BankDetails("DE88200800000970375700", "COBADEFFXXX"))).setRecipient(new TradeParty("Franz Müller", "teststr.12", "55232", "Entenhausen", "DE").addVATID("DE0815")).setNumber(number)
 				.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), price, qty))
 				.addItem(new Item(new Product("Testprodukt", "", "C62", new BigDecimal(19)), price, qty))