Enhance code quality

This commit is contained in:
Daniel Luckas
2025-07-17 10:27:25 +02:00
parent adab361477
commit 7ebaf3af8a
2 changed files with 5 additions and 5 deletions

View File

@@ -57,7 +57,7 @@ public class OXPullProvider extends ZUGFeRD2PullProvider {
paymentTermsDescription = XMLTools.encodeXML(trans.getPaymentTermDescription()); paymentTermsDescription = XMLTools.encodeXML(trans.getPaymentTermDescription());
} }
if (paymentTermsDescription == null && !trans.getDocumentCode().equals(CORRECTEDINVOICE)/* && (trans.getDocumentCode() != DocumentCodeTypeConstants.CREDITNOTE)*/) { if (paymentTermsDescription == null && !CORRECTEDINVOICE.equals(trans.getDocumentCode())/* && (trans.getDocumentCode() != DocumentCodeTypeConstants.CREDITNOTE)*/) {
paymentTermsDescription = "Zahlbar ohne Abzug bis " + germanDateFormat.format(trans.getDueDate()); paymentTermsDescription = "Zahlbar ohne Abzug bis " + germanDateFormat.format(trans.getDueDate());
} }

View File

@@ -361,8 +361,8 @@ public class ZUGFeRD2PullProvider implements IXMLProvider {
paymentTermsDescription += discount.getAsXRechnung(); paymentTermsDescription += discount.getAsXRechnung();
} }
} else if (paymentTermsDescription == null } else if (paymentTermsDescription == null
&& !trans.getDocumentCode().equals(DocumentCodeTypeConstants.CORRECTEDINVOICE) && !DocumentCodeTypeConstants.CORRECTEDINVOICE.equals(trans.getDocumentCode())
&& !trans.getDocumentCode().equals(DocumentCodeTypeConstants.CREDITNOTE) && !DocumentCodeTypeConstants.CREDITNOTE.equals(trans.getDocumentCode())
) { ) {
if (trans.getDueDate() != null) { if (trans.getDueDate() != null) {
paymentTermsDescription = "Please remit until " + germanDateFormat.format(trans.getDueDate()); paymentTermsDescription = "Please remit until " + germanDateFormat.format(trans.getDueDate());
@@ -721,8 +721,8 @@ public class ZUGFeRD2PullProvider implements IXMLProvider {
} }
} }
} }
if (trans.getDocumentCode().equals(DocumentCodeTypeConstants.CORRECTEDINVOICE) if (DocumentCodeTypeConstants.CORRECTEDINVOICE.equals(trans.getDocumentCode())
|| trans.getDocumentCode().equals(DocumentCodeTypeConstants.CREDITNOTE) || DocumentCodeTypeConstants.CREDITNOTE.equals(trans.getDocumentCode())
) { ) {
hasDueDate = false; hasDueDate = false;
} }