From be2d57e3e33ed7b3694308334e9a74efa69bca97 Mon Sep 17 00:00:00 2001
From: Philip Helger <philip@helger.com>
Date: Tue, 9 Jul 2024 17:32:23 +0200
Subject: [PATCH] Make sure to close streams

---
 .../mustangproject/validator/XMLValidator.java | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/validator/src/main/java/org/mustangproject/validator/XMLValidator.java b/validator/src/main/java/org/mustangproject/validator/XMLValidator.java
index aa9449cc..ef1f40b7 100644
--- a/validator/src/main/java/org/mustangproject/validator/XMLValidator.java
+++ b/validator/src/main/java/org/mustangproject/validator/XMLValidator.java
@@ -1,5 +1,6 @@
 package org.mustangproject.validator;
 import com.helger.schematron.ISchematronResource;
+import com.helger.schematron.svrl.SVRLHelper;
 import com.helger.schematron.svrl.SVRLMarshaller;
 import com.helger.schematron.svrl.jaxb.SchematronOutputType;
 import org.mustangproject.XMLTools;
@@ -21,6 +22,7 @@ import java.io.IOException;
 import java.io.PrintWriter;
 import java.io.StringReader;
 import java.io.StringWriter;
+import java.io.UncheckedIOException;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Paths;
@@ -63,11 +65,16 @@ public class XMLValidator extends Validator {
 
 				final ValidationResultItem vri = new ValidationResultItem(ESeverity.exception, e.getMessage()).setSection(9)
 					.setPart(EPart.fx);
-				final StringWriter sw = new StringWriter();
-				final PrintWriter pw = new PrintWriter(sw);
-				e.printStackTrace(pw);
-				vri.setStacktrace(sw.toString());
-				context.addResultItem(vri);
+				try (final StringWriter sw = new StringWriter();
+			       final PrintWriter pw = new PrintWriter(sw))
+				{
+  				e.printStackTrace(pw);
+  				vri.setStacktrace(sw.toString());
+  				context.addResultItem(vri);
+				}
+        catch (IOException ex) {
+          throw new UncheckedIOException (ex);
+        }
 			}
 
 		}
@@ -433,6 +440,7 @@ public class XMLValidator extends Validator {
 			} catch (final Exception e) {
 				throw new IrrecoverableValidationError(e.getMessage());
 			}
+			// SVRLHelper.getAllFailedAssertions (sout);
 			Document SVRLReport = new SVRLMarshaller().getAsDocument(sout);
 			XPath xPath = XPathFactory.newInstance().newXPath();
 			String expression = "//*[local-name() = 'failed-assert']";